Re: [PATCH 2/4] media: mediatek: vcodec: Drop unnecessary variable
From: AngeloGioacchino Del Regno
Date: Wed Dec 06 2023 - 05:19:45 EST
Il 13/11/23 13:26, Fei Shao ha scritto:
It's unclear why only mem->size has local copies without particular
usage in mtk_vcodec_mem_alloc() and mtk_vcodec_mem_free(), and they
seem removable.
Drop them to make the code visually consistent, and update printk format
identifier accordingly.
Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx>
That's probably just about personal preferences, as mem->size is not expected
to change during the flow of those functions.
That said, as much as you, I prefer not having this local copy as it's using
(a very small amount of) memory for no real reason anyway, so:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>