Re: [PATCH v3 1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1

From: Krzysztof Kozlowski
Date: Tue Dec 19 2023 - 02:17:56 EST


On 19/12/2023 01:31, Tengfei Fan wrote:
> The address/size-cells in mdss_dsi1 node have not ranges and child also
> have not reg, then this leads to dtc W=1 warnings:

I cannot parse it. Address/size cells never have ranges or children.
They cannot have. These are uint32 properties.

>
> sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> ---

I disagreed with the patch before. You resubmit it without really
addressing my concerns.

I am not sure if this is correct fix and I want to fix all of such
errors (there are multiple of them) in the same way. Feel free to
propose common solution based on arguments.

I don't really want to NAKit but since you are resending without
finishing the discussion, which is quite impolite, then let's be like that:

NAK

Best regards,
Krzysztof