On 17/01/2024 10:37, Tim Lunn wrote:Right, but I am not actually adding any clocks, just documenting what is already there.
Description. But anyway the problem is that adding clocks should beYou can drop the description.Yes just 1 clock, i will fix this.
Just drop the description? I dont think can drop the clock names as the+Drop.
+ clock-names:
+ description:
+ The clock name for the codec clock.
driver use the name to lookup clock:
separate patch with its own explanation.
Got it, I will clarify this and future commit messages
devm_clk_get(pdev->dev.parent, "mclk");You need to clearly express ABI requirements in the commit msg.
Ok+ items:Common property, don't need the description.
+ - const: mclk
+
+ '#sound-dai-cells':
+ description:
+ Needed for the interpretation of sound dais.
This is how the existing rk817 codec driver was setup. I suppose it was+ const: 0Why do you need a child node here? Just put the 1 property in the parent
+
+ codec:
+ description: |
+ The child node for the codec to hold additional properties. If no
+ additional properties are required for the codec, this node can be
+ omitted.
node.
copied from downstream, where there are more properties than just the
one. I don't know if there was any intention (or need) to implement
those other properties.
Otherwise you will get a review like for new bindings.
Best regards,
Krzysztof