Re: [PATCH v2 1/1] RDMA/srpt: Do not register event handler until srpt device is fully setup

[Leon Romanovsky]

On Fri, Feb 02, 2024 at 02:15:49AM -0700, William Kucharski wrote:
> Upon rare occasions, KASAN reports a use-after-free Write
> in srpt_refresh_port().
> 
> This seems to be because an event handler is registered before the
> srpt device is fully setup and a race condition upon error may leave a
> partially setup event handler in place.
> 
> Instead, only register the event handler after srpt device initialization
> is complete.
> 
> Fixes: dcc9881e6767 ("RDMA/(core, ulp): Convert register/unregister event handler to be void")

This is wrong line, the issues is much older.
Fixes: a42d985bd5b2 ("ib_srpt: Initial SRP Target merge for v3.3-rc1")

> Signed-off-by: William Kucharski <william.kucharski@xxxxxxxxxx>

Please keep Reviewed-by tags provided by Bart.

Thanks