Re: [PATCH 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

[Hannes Reinecke]

On 1/31/24 00:42, Lee Duncan wrote:
> From: Lee Duncan <lduncan@xxxxxxxx>
>
> This reverts commit 1a1975551943f681772720f639ff42fbaa746212
>
> This commit causes interrupts to be lost for FCoE devices,
> since it changed sping locks from "bh" to "irqsave".
>
> Instead, a work queue should be used, and will be addressed
> in a separate patch.
>
> Fixes: 1a1975551943f681772720f639ff42fbaa746212
> Signed-off-by: Lee Duncan <lduncan@xxxxxxxx>
> ---
>   drivers/scsi/fcoe/fcoe_ctlr.c | 20 ++++++++------------
>   1 file changed, 8 insertions(+), 12 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich