Re: [PATCH stable 5.15 v2] net: bcmgenet: Fix EEE implementation

From: Florian Fainelli
Date: Sun Feb 11 2024 - 20:50:07 EST




On 2/11/2024 8:36 AM, Sasha Levin wrote:
On Thu, Feb 08, 2024 at 11:06:05AM -0800, Florian Fainelli wrote:
[ Upstream commit a9f31047baca57d47440c879cf259b86f900260c ]

We had a number of short comings:

- EEE must be re-evaluated whenever the state machine detects a link
 change as wight be switching from a link partner with EEE
 enabled/disabled

- tx_lpi_enabled controls whether EEE should be enabled/disabled for the
 transmit path, which applies to the TBUF block

- We do not need to forcibly enable EEE upon system resume, as the PHY
 state machine will trigger a link event that will do that, too

Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@xxxxxxxxxxxx
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

It doesn't look like this one applies to 5.15...


Yes I based it off an incorrect branch that has additional changes queued up locally, v3 coming shortly, thanks!
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature