Re: [PATCH net-next v9 6/9] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core
From: Krzysztof Kozlowski
Date: Fri Mar 08 2024 - 03:01:15 EST
On 07/03/2024 12:34, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
>
> HiSilicon FEMAC core is also found on Hi3798MV200 SoC. Document it in
> binding.
>
> Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
>
> # Conflicts:
> # Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
Drop
> ---
> Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> index 5cd2331668bc..4f8a07864eb4 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> @@ -16,6 +16,7 @@ properties:
> compatible:
> enum:
> - hisilicon,hi3516cv300-femac
> + - hisilicon,hi3798mv200-femac
As I asked two or three or four times: please express compatibility
(oneOf, items). Your driver suggests that they are compatible. If they
are not compatible, mention it in commit msg, but so far it suggests
they are compatible.
Best regards,
Krzysztof