Re: [PATCH] HID: bpf: fix hid_bpf_input_report() when hid-core is not ready

From: Benjamin Tissoires
Date: Thu Apr 11 2024 - 05:57:49 EST


On Apr 11 2024, Benjamin Tissoires wrote:
> On Apr 11 2024, Jiri Kosina wrote:
> > On Thu, 11 Apr 2024, Benjamin Tissoires wrote:
> >
> > > Reported by linux-next:
> > > After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > x86_64-linux-gnu-ld: vmlinux.o: in function `hid_bpf_input_report':
> > > (.text+0x1c75181): undefined reference to `hid_input_report'
> > >
> > > Caused by commit 9be50ac30a83 ("HID: bpf: allow to inject HID event
> > > from BPF")
> > >
> > > I just forgot to put the indirection in place.
> > >
> > > Link: https://lore.kernel.org/linux-kernel/20240411105131.7830f966@xxxxxxxxxxxxxxxx/
> > > Signed-off-by: Benjamin Tissoires <bentiss@xxxxxxxxxx>
> >
> > Please also include Fixes: tag.
>
> Oops, correct. I'll add the following (in case b4 is smart enough to
> pick it up by itself):

FTR, b4 is actually smart enough to pick this one up :)

>
> Fixes: 9be50ac30a83 ("HID: bpf: allow to inject HID event from BPF")
>
Cheers,
Benjamin