Re: [PATCH v1 1/1] fpga: ice40-spi: Remove redundant of_match_ptr() macros

From: Andy Shevchenko
Date: Mon Apr 15 2024 - 09:29:37 EST


On Sat, Apr 13, 2024 at 10:56:10AM +0800, Xu Yilun wrote:
> On Fri, Apr 12, 2024 at 06:58:30PM +0300, Andy Shevchenko wrote:
> > Since the driver hi6421-regulator depends on CONFIG_OF,
> ^
> It is ice40-spi

Oops, copy-and-paste typo.

> > it makes no difference to wrap of_match_ptr() here.
> >
> > Remove of_match_ptr() macros to clean it up.
> >
> > While at it, add missing mod_devicetable.h.
> >
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Closes: https://lore.kernel.org/r/20240412151147.22a059ff@xxxxxxxxxxxxxxxx
> > Fixes: 5d04660b29fb ("fpga: ice40-spi: Remove unused of_gpio.h")
>
> Since 5d04660b29fb is not merged yet, could you just merge them into one?
> Or it breaks bisecting.

You can also fold it, but sure, I'll send a v2.

--
With Best Regards,
Andy Shevchenko