RE: [EXTERNAL] [PATCH net] octeontx2-af: fix the double free in rvu_npc_freemem()

[Geethasowjanya Akula]

> -----Original Message-----
> From: Su Hui <suhui@xxxxxxxxxxxx>
> Sent: Wednesday, April 24, 2024 7:57 AM
> To: Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Linu Cherian
> <lcherian@xxxxxxxxxxx>; Geethasowjanya Akula <gakula@xxxxxxxxxxx>;
> Jerin Jacob <jerinj@xxxxxxxxxxx>; Hariprasad Kelam
> <hkelam@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta
> <sbhatta@xxxxxxxxxxx>; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; nathan@xxxxxxxxxx;
> ndesaulniers@xxxxxxxxxx; morbo@xxxxxxxxxx; justinstitt@xxxxxxxxxx
> Cc: Su Hui <suhui@xxxxxxxxxxxx>; Suman Ghosh <sumang@xxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; llvm@xxxxxxxxxxxxxxx;
> kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [EXTERNAL] [PATCH net] octeontx2-af: fix the double free in
> rvu_npc_freemem()
> ----------------------------------------------------------------------
> Clang static checker(scan-build) warning：
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:line 2184, column 2
> Attempt to free released memory.
> 
> npc_mcam_rsrcs_deinit() has released 'mcam->counters.bmap'. Deleted this
> redundant kfree() to fix this double free problem.
> 
> Fixes: dd7842878633 ("octeontx2-af: Add new devlink param to configure
> maximum usable NIX block LFs")
> Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> index be709f83f331..e8b73b9d75e3 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -2181,7 +2181,6 @@ void rvu_npc_freemem(struct rvu *rvu)
> 
>  	kfree(pkind->rsrc.bmap);
>  	npc_mcam_rsrcs_deinit(rvu);
> -	kfree(mcam->counters.bmap);
>  	if (rvu->kpu_prfl_addr)
>  		iounmap(rvu->kpu_prfl_addr);
>  	else
> --
> 2.30.2
Reviewed-by: Geetha sowjanya <gakula@xxxxxxxxxxx>