RE: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops

From: Peng Fan
Date: Wed Apr 24 2024 - 03:06:12 EST


> Subject: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops
>
> 'struct lcd_ops' is not modified by core backlight code, so it can be made
> const for increased code safety.
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Reviewed-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>
> Depends on the first patch in the series.
> ---
> drivers/video/fbdev/imxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index
> a4dbc72f93c3..4ebfe9b9df60 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -857,7 +857,7 @@ static int imxfb_lcd_set_power(struct lcd_device
> *lcddev, int power)
> return 0;
> }
>
> -static struct lcd_ops imxfb_lcd_ops = {
> +static const struct lcd_ops imxfb_lcd_ops = {
> .check_fb = imxfb_lcd_check_fb,
> .get_contrast = imxfb_lcd_get_contrast,
> .set_contrast = imxfb_lcd_set_contrast,
>
> --
> 2.43.0
>