Re: [PATCH net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns()

From: Roger Quadros
Date: Wed Apr 24 2024 - 03:28:10 EST




On 23/04/2024 19:15, Dan Carpenter wrote:
> The rx_chn->irq[] array is unsigned int but it should be signed for the
> error handling to work. Also if k3_udma_glue_rx_get_irq() returns zero
> then we should return -ENXIO instead of success.
>
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>