Re: [PATCH 1/2] pwm: meson: drop unneeded check in get_state callback

[George Stark]

Hello Uwe

Thanks for the review

On 4/24/24 10:19, Uwe Kleine-König wrote:
> Hello George,
>
> On Tue, Apr 23, 2024 at 07:13:55PM +0300, George Stark wrote:
> > Drop checking state argument for null pointer in meson_pwm_get_state()
> > due to it is called only from pwm core with always valid arguments.
> >
> > Fixes: 211ed630753d ("pwm: Add support for Meson PWM Controller")
> > Signed-off-by: George Stark <gnstark@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxxxxx>
>
> I'd apply this one with the following changes if you agree:
>
>   - capitalize "drop" in the Subject line
>   - s/get_state/.get_state()/
>   - make "null" all caps (i.e. "NULL")
>   - swap the order of Signed-off-by lines to have yours last.
>
> Alternatively send it in a v2 together with addressing the comment in
> the second patch.

I agree with the proposed changes and
I'll clean it up after myself in v2

> Best regards
> Uwe

--
Best regards
George