Re: [net-next PATCH v2] octeontx2-pf: Add ucast filter count configurability via devlink.

From: Sai Krishna Gajula
Date: Wed Apr 24 2024 - 04:32:48 EST



> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Tuesday, April 23, 2024 2:49 AM
> To: Sai Krishna Gajula <saikrishnag@xxxxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham
> <sgoutham@xxxxxxxxxxx>; Geethasowjanya Akula <gakula@xxxxxxxxxxx>;
> Hariprasad Kelam <hkelam@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta
> <sbhatta@xxxxxxxxxxx>
> Subject: Re: [net-next PATCH v2] octeontx2-pf: Add ucast filter
> count configurability via devlink.
>
> On Fri, 19 Apr 2024 00:30:31 +0530 Sai Krishna wrote:
> > +
> DEVLINK_PARAM_DRIVER(OTX2_DEVLINK_PARAM_ID_UCAST_FLT_C
> NT,
> > + "unicast_filter_count", DEVLINK_PARAM_TYPE_U8,
> > + BIT(DEVLINK_PARAM_CMODE_RUNTIME),
> > + otx2_dl_ucast_flt_cnt_get,
> otx2_dl_ucast_flt_cnt_set,
> > + otx2_dl_ucast_flt_cnt_validate),
>
> All devlink params must be documented
> (Documentation/networking/devlink)
> including the explanation of the tradeoffs involved in changing the setting.

Ack, will add the documentation details and submit patch V3

> --
> pw-bot: cr