Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed

From: Hongbo Li
Date: Wed Apr 24 2024 - 04:44:49 EST


ok, thanks!

On 2024/4/24 11:29, Gao Xiang wrote:

(+cc linux-erofs & LKML)

On 2024/4/24 10:39, Hongbo Li wrote:
When prepare_ondemand_read failed, wrong error message is printed.
The prepare_read is also implemented in cachefiles, so we amend it.

Signed-off-by: Hongbo Li <lihongbo22@xxxxxxxxxx>

Reviewed-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Could you resend the patch with proper mailing list cced with my
"reviewed-by:" tag?  So I could apply with "b4" tool.

Thanks,
Gao Xiang

---
  fs/erofs/fscache.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 8aff1a724805..62da538d91cb 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
          if (WARN_ON(len == 0))
              source = NETFS_INVALID_READ;
          if (source != NETFS_READ_FROM_CACHE) {
-            erofs_err(NULL, "prepare_read failed (source %d)", source);
+            erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
              return -EIO;
          }