Re: [PATCH] mm,swap: cleanup VMA based swap readahead window calculation

[David Hildenbrand]

On 24.04.24 08:30, Huang Ying wrote:
> When VMA based swap readahead is introduced in commit
> ec560175c0b6 ("mm, swap: VMA based swap readahead"), "struct
> vma_swap_readahead" is defined to describe the readahead window.
> Because we wanted to save the PTE entries in the struct at that time.
> But after commit 4f8fcf4ced0b ("mm/swap: swap_vma_readahead() do the
> pte_offset_map()"), we no longer save PTE entries in the struct.  The
> size of the struct becomes so small, that it's better to use the
> fields of the struct directly.  This can simplify the code to improve
> the code readability.  The line number of source code reduces too.
>
> No functionality change is expected in this patch.

From a quick scan, you perform quite some unrelated changes that make 
the code harder to review than it should be. Consider separating any 
cleanups from the core change of removing the struct.

--
Cheers,

David / dhildenb