Re: [PATCH v1 14/16] thermal: gov_user_space: Use .trip_crossed() instead of .throttle()

From: Daniel Lezcano
Date: Wed Apr 24 2024 - 07:34:49 EST


On 24/04/2024 13:32, Srinivas Pandruvada wrote:

On 4/24/24 02:14, Daniel Lezcano wrote:
On Wed, Apr 10, 2024 at 07:03:10PM +0200, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Notifying user space about trip points that have not been crossed is
not particuarly useful, so modity the User Space governor to use the
.trip_crossed() callback, which is only invoked for trips that have been
crossed, instead of .throttle() that is invoked for all trips in a
thermal zone every time the zone is updated.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

I would also consider removing this governor which is pointless now that we
have the netlink notification mechanism

That is a good goal, But, not there yet to deprecate.

What can be done to deprecate it ?


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog