RE: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys

From: Havalige, Thippeswamy
Date: Wed Apr 24 2024 - 08:37:40 EST


Tested-by: thippeswamy.havalige@xxxxxxx

> -----Original Message-----
> From: Simek, Michal <michal.simek@xxxxxxx>
> Sent: Wednesday, April 24, 2024 4:57 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@xxxxxxx>; Sean Anderson
> <sean.anderson@xxxxxxxxx>; Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>; Krzysztof
> Wilczyński <kw@xxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; linux-
> pci@xxxxxxxxxxxxxxx; Gogada, Bharat Kumar <bharat.kumar.gogada@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Bjorn
> Helgaas <bhelgaas@xxxxxxxxxx>
> Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
>
>
>
> On 4/24/24 11:11, Havalige, Thippeswamy wrote:
> > Hi Michal,
> >
> >> -----Original Message-----
> >> From: Simek, Michal <michal.simek@xxxxxxx>
> >> Sent: Tuesday, April 23, 2024 11:46 AM
> >> To: Sean Anderson <sean.anderson@xxxxxxxxx>; Lorenzo Pieralisi
> >> <lpieralisi@xxxxxxxxxx>; Krzysztof Wilczyński <kw@xxxxxxxxx>; Rob
> >> Herring <robh@xxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; Gogada, Bharat
> >> Kumar <bharat.kumar.gogada@xxxxxxx>
> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> >> linux-kernel@xxxxxxxxxxxxxxx; Havalige, Thippeswamy
> >> <thippeswamy.havalige@xxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >> Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
> >>
> >> Hi Bharat,
> >>
> >> On 4/22/24 21:59, Sean Anderson wrote:
> >>> Add PCIe phy bindings for the ZCU102.
> >>>
> >>> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxxx>
> >>> ---
> >>> I don't have a ZCU102, so please test this.
> >>>
> >>> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >> b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >>> index ad8f23a0ec67..68fe53685351 100644
> >>> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >>> @@ -941,6 +941,8 @@ conf-pull-none {
> >>>
> >>> &pcie {
> >>> status = "okay";
> >>> + phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>;
> >>> + phy-names = "pcie-phy0";
> >>> };
> >>>
> >>> &psgtr {
> >>
> >> Please review and test this series.
> >>
> >> Thanks,
> >> Michal
> >
> > Reviewed and tested the patch.
>
> can you please provide proper Tested-by: line?
>
> Thanks,
> Michal