Re: [PATCH v3 0/2] fw_devlink overlay fix
From: Geert Uytterhoeven
Date: Wed Apr 24 2024 - 09:42:53 EST
Hi Saravana,
On Fri, Apr 12, 2024 at 1:56 AM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> Overlays don't work correctly with fw_devlink. This patch series fixes
> it. This series is now ready for review and merging once Geert and Herve
> give they Tested-by.
>
> Geert and Herve,
>
> This patch series should hopefully fix both of your use cases [1][2][3].
> Can you please check to make sure the device links created to/from the
> overlay devices are to/from the right ones?
Unfortunately it doesn't, and the result is worse than v2.
After applying the first patch (the revert), the issue reported in
[1] is back, as expected.
After applying both patches, that issue is not fixed, i.e. I still
need an add/rm/add cycle to instantiate the devices from the overlay.
/sys/class/devlink shows one extra link after the first add:
platform:e6060000.pinctrl--platform:e6e90000.spi ->
./../devices/virtual/devlink/platform:e6060000.pinctrl--platform:e6e90000.spi
> [1] - https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@xxxxxxxxxxxxxx/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds