Re: [PATCH v2 1/1] ALSA: control: Use list_for_each_entry_safe()

From: Andy Shevchenko
Date: Wed Apr 24 2024 - 10:50:03 EST


On Wed, Apr 24, 2024 at 09:24:49AM +0200, Takashi Iwai wrote:
> On Tue, 23 Apr 2024 23:10:22 +0200,
> Andy Shevchenko wrote:
> >
> > Instead of reiterating the list, use list_for_each_entry_safe()
> > that allows to continue without starting over.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Reviewed-by: Jaroslav Kysela <perex@xxxxxxxx>
> > ---
> > v2: added tag (Jaroslav)
>
> We have a similar repeat in snd_ctl_led_reset().
> Wouldn't it be better to catch both?

Sure, v3 is on its way.

--
With Best Regards,
Andy Shevchenko