Re: [PATCH net-next] net: qede: flower: validate control flags

[Asbjørn Sloth Tønnesen]

Hi Jiri,

On 4/24/24 2:52 PM, Jiri Pirko wrote:
> Wed, Apr 24, 2024 at 03:42:48PM CEST, ast@xxxxxxxxxxx wrote:
> > This driver currently doesn't support any flower control flags.
> >
> > Implement check for control flags, such as can be set through
> > `tc flower ... ip_flags frag`.
> >
> > Since qede_parse_flow_attr() are called by both qede_add_tc_flower_fltr()
> > and qede_flow_spec_to_rule(), as the latter doesn't having access to
> > extack, then flow_rule_*_control_flags() can't be used in this driver.
>
> Why? You can pass null.

Ah, I see. I hadn't traced that option down through the defines,
I incorrectly assumed that NL_SET_ERR_MSG* didn't allow NULL.

Currently thinking about doing v2 in this style:

if (flow_rule_match_has_control_flags(rule, extack)) {
        if (!extack)
                DP_NOTICE(edev, "Unsupported match on control.flags");
        return -EOPNOTSUPP;
}

pw-bot: changes-requested

--
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541