Re: [PATCH v2] RISC-V: clarify what some RISCV_ISA* config options do

From: Andrew Jones
Date: Wed Apr 24 2024 - 12:46:31 EST


On Wed, Apr 24, 2024 at 05:25:21PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> During some discussion on IRC yesterday and on Pu's bpf patch [1]
> I noticed that these RISCV_ISA* Kconfig options are not really clear
> about their implications. Many of these options have no impact on what
> userspace is allowed to do, for example an application can use Zbb
> regardless of whether or not the kernel does. Change the help text to
> try and clarify whether or not an option affects just the kernel, or
> also userspace. None of these options actually control whether or not an
> extension is detected dynamically as that's done regardless of Kconfig
> options, so drop any text that implies the option is required for
> dynamic detection, rewording them as "do x when y is detected".
>
> Link: https://lore.kernel.org/linux-riscv/20240328-ferocity-repose-c554f75a676c@spud/ [1]
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
>
> Since this is a commit entirely about wording, I dropped both R-bs for
> v2 as, while my intent hasn't changed, I've come up with a new set of
> wordings.
> v2 redoes some of the "detected by the kernel" wording to avoid stuff that
> Drew pointed out was redundant & adds a wee bit more wording to the C
> extension's stuff to be clear that it is a build time option.
>
> CC: Samuel Holland <samuel.holland@xxxxxxxxxx>
> CC: Pu Lehui <pulehui@xxxxxxxxxxxxxxx>
> CC: Björn Töpel <bjorn@xxxxxxxxxx>
> CC: Andrew Jones <ajones@xxxxxxxxxxxxxxxx>
> CC: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> CC: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> CC: linux-riscv@xxxxxxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
> arch/riscv/Kconfig | 36 +++++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>

Reviewed-by: Andrew Jones <ajones@xxxxxxxxxxxxxxxx>