Re: [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

From: Rob Herring
Date: Wed Apr 24 2024 - 16:11:18 EST


On Wed, Apr 24, 2024 at 01:13:17PM +0800, Ji Sheng Teoh wrote:
> Document the optional reset control to SPI.
>
> Signed-off-by: Eng Lee Teh <englee.teh@xxxxxxxxxxxxxxxx>
> Signed-off-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@xxxxxxxxxxxxxxxx>

3 people developed 4 lines of code? Generally the first S-o-b should be
the author (.i.e. a From line).

> ---
> Documentation/devicetree/bindings/spi/spi-cadence.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index d4b61b0e8301..2358489be4bc 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -55,6 +55,11 @@ properties:
> label:
> description: Descriptive name of the SPI controller.
>
> + resets:
> + description: |
> + Optional entry to specify the reset controller to the SPI

Drop the description.

> + maxItems: 1
> +
> required:
> - compatible
> - reg
> --
> 2.43.2
>