Re: [PATCH v5 4/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
From: kernel test robot
Date: Wed Apr 24 2024 - 19:33:56 EST
Hi Longfang,
kernel test robot noticed the following build errors:
[auto build test ERROR on awilliam-vfio/next]
[also build test ERROR on linus/master v6.9-rc5 next-20240424]
[cannot apply to awilliam-vfio/for-linus]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Longfang-Liu/hisi_acc_vfio_pci-extract-public-functions-for-container_of/20240424-170806
base: https://github.com/awilliam/linux-vfio.git next
patch link: https://lore.kernel.org/r/20240424085721.12760-5-liulongfang%40huawei.com
patch subject: [PATCH v5 4/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20240425/202404250711.4mzD3Fe0-lkp@xxxxxxxxx/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 5ef5eb66fb428aaf61fb51b709f065c069c11242)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240425/202404250711.4mzD3Fe0-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404250711.4mzD3Fe0-lkp@xxxxxxxxx/
All error/warnings (new ones prefixed by >>):
In file included from drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:9:
In file included from include/linux/hisi_acc_qm.h:10:
In file included from include/linux/pci.h:38:
In file included from include/linux/interrupt.h:21:
In file included from arch/riscv/include/asm/sections.h:9:
In file included from include/linux/mm.h:2208:
include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
509 | item];
| ~~~~
include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
516 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
528 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
537 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1370:46: error: too few arguments provided to function-like macro invocation
1370 | dev_err("mailbox cmd channel state is OK!\n");
| ^
include/linux/dev_printk.h:143:9: note: macro 'dev_err' defined here
143 | #define dev_err(dev, fmt, ...) \
| ^
>> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1370:2: error: use of undeclared identifier 'dev_err'; did you mean '_dev_err'?
1370 | dev_err("mailbox cmd channel state is OK!\n");
| ^~~~~~~
| _dev_err
include/linux/dev_printk.h:50:6: note: '_dev_err' declared here
50 | void _dev_err(const struct device *dev, const char *fmt, ...);
| ^
>> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1370:2: warning: expression result unused [-Wunused-value]
1370 | dev_err("mailbox cmd channel state is OK!\n");
| ^~~~~~~
6 warnings and 2 errors generated.
vim +1370 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
1345
1346 static int hisi_acc_vf_debug_cmd(struct seq_file *seq, void *data)
1347 {
1348 struct device *vf_dev = seq->private;
1349 struct vfio_pci_core_device *core_device = dev_get_drvdata(vf_dev);
1350 struct vfio_device *vdev = &core_device->vdev;
1351 struct hisi_acc_vf_core_device *hisi_acc_vdev = hisi_acc_get_vf_dev(vdev);
1352 struct hisi_qm *vf_qm = &hisi_acc_vdev->vf_qm;
1353 u64 value;
1354 int ret;
1355
1356 mutex_lock(&hisi_acc_vdev->enable_mutex);
1357 ret = hisi_acc_vf_debug_check(seq, vdev);
1358 if (ret) {
1359 mutex_unlock(&hisi_acc_vdev->enable_mutex);
1360 return ret;
1361 }
1362
1363 value = readl(vf_qm->io_base + QM_MB_CMD_SEND_BASE);
1364 if (value == QM_MB_CMD_NOT_READY) {
1365 mutex_unlock(&hisi_acc_vdev->enable_mutex);
1366 dev_err(vf_dev, "mailbox cmd channel not ready!\n");
1367 return -EINVAL;
1368 }
1369 mutex_unlock(&hisi_acc_vdev->enable_mutex);
> 1370 dev_err("mailbox cmd channel state is OK!\n");
1371
1372 return 0;
1373 }
1374
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki