Re: ynl: maybe minor bug?

From: Jakub Kicinski
Date: Wed Apr 24 2024 - 19:43:23 EST


On Wed, 24 Apr 2024 16:19:49 -0700 Joe Damato wrote:
> I'm not sure whether:
>
> 1. tools/net/ynl/lib/ynl.py should be raising NlError when there is an
> extack in this case (I think this is probably the way to go?), or
>
> 2. the tests should be changed so that they don't expect an exception to be
> raised but (ideally?) hide the warning report from tools/net/ynl/lib/ynl.py
> when the warning is expected.
>
> I don't know python at all so this is definitely wrong, but here's a small
> change I made to fix the test (a similar change was made for the test which
> follows).

Sorry about this, we pushed the related fix to the net tree, to get it
to Linus sooner:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=a44f2eb106a46f2275a79de54ce0ea63e4f3d8c8

You can cherry-pick that locally, perhaps. net will get merged into
net-next tomorrow, I should have waited before extending the test :(