Re: [PATCH v2] hfsplus: refactor copy_name to not use strncpy

From: Kees Cook
Date: Wed Apr 24 2024 - 19:55:51 EST


On Mon, 01 Apr 2024 18:10:48 +0000, Justin Stitt wrote:
> strncpy() is deprecated with NUL-terminated destination strings [1].
>
> The copy_name() method does a lot of manual buffer manipulation to
> eventually arrive with its desired string. If we don't know the
> namespace this attr has or belongs to we want to prepend "osx." to our
> final string. Following this, we're copying xattr_name and doing a
> bizarre manual NUL-byte assignment with a memset where n=1.
>
> [...]

Applied to for-next/hardening, thanks!

[1/1] hfsplus: refactor copy_name to not use strncpy
https://git.kernel.org/kees/c/628a89b6ef79

Take care,

--
Kees Cook