Re: [PATCH 01/10] dt-bindings: pwm: Add SI-EN SN3112 PWM support
From: Uwe Kleine-König
Date: Thu Apr 25 2024 - 02:05:38 EST
Hello,
On Wed, Apr 24, 2024 at 11:29:06PM +0800, Xilin Wu via B4 Relay wrote:
> From: Junhao Xie <bigfoot@xxxxxxxxxxx>
>
> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
>
> Signed-off-by: Junhao Xie <bigfoot@xxxxxxxxxxx>
Missing S-o-b for patch submitter.
> + "#pwm-cells":
> + const: 1
please use 3 here (which is also what the driver implements)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature