Re: [PATCH net-next 2/4] net: add support for segmenting TCP fraglist GSO packets

[Felix Fietkau]

On 25.04.24 05:03, Willem de Bruijn wrote:
> Felix Fietkau wrote:
> > Preparation for adding TCP fraglist GRO support. It expects packets to be
> > combined in a similar way as UDP fraglist GSO packets.
> > One difference is the fact that this code assumes that the TCP flags of
> > all packets have the same value. This allows simple handling of flags
> > mutations.
>
> Can you clarify this some more? We expect potentially different flags
> on first and last packet in a TSO train. With fraglist, the segments
> keep their original flags, as the headers are only pulled. When do
> segment flags need to be replaced with those of the first segment?

Maybe I just misunderstood a comment that Paolo made earlier regarding 
TCP header mutations. Will review this again and compare with regular TSO.

- Felix