Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function

From: Andy Shevchenko
Date: Thu Apr 25 2024 - 05:46:00 EST


On Thu, Apr 25, 2024 at 12:15:32PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 25, 2024 at 02:25:24PM +0800, Miaohe Lin wrote:
> > On 2024/4/24 0:14, Andy Shevchenko wrote:

..

> > > In some configurations I got
> > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> > > Becuase the only user is guarged with a certain ifdeffery,
> >
> > guarged?
>
> A typo, thanks!

FWIW, Andrew fixed this along with "Because". Thank you, Andrew!

> > ifdeffery?
>
> Yes, this is established term.
>
> > > do the same for add_to_free_list().

--
With Best Regards,
Andy Shevchenko