Re: [PATCH v3 1/7] ASoC: dt-bindings: document wcd937x Audio Codec

From: Krzysztof Kozlowski
Date: Thu Apr 25 2024 - 07:53:38 EST


On 25/04/2024 13:47, Mohammad Rafi Shaik wrote:
> On 4/25/2024 4:31 PM, Krzysztof Kozlowski wrote:
>> On 25/04/2024 11:18, Mohammad Rafi Shaik wrote:
>>> From: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
>>>
>>> Document the Qualcomm WCD9370/WCD9375 Audio Codec and the soundwire
>>> devices can be found on Qualcomm QCM6490 based platforms.
>>>
>>> The Qualcomm WCD9370/WCD9375 Audio Codec communicates
>>> with the host SoC over 2 Soundwire links to provide:
>>> - 3 TX ADC paths with 4 differential AMIC inputs
>>> - 6 DMIC inputs that are shared with AMIC input
>>> - 4 Microphone BIAS
>>> - RX paths with 4 PAs – HPHL/R, EAR and AUX
>>> - Stereo Headphone output
>>> - MBHC engine for Headset Detection
>>>
>>> Co-developed-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
>>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
>>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
>>
>> 1. That's odd order of tags. Who created the first patch?
>
> First patch is created by : Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>

So look at submitting patches explaining the order.


>>
>> 2. Last time you received report that this was not tested. Now there is
>> again report.
>> Are you sure you test patches before sending?
>>
> Yes i have tested patches multiple times before sending.
>
> In my setup the "make dt_binding_check" became success, there is no
> errors.
>

I can easily reproduce the errors, so you probably don't have yamllint
and use old dtschema and/or old kernel.



Best regards,
Krzysztof