Re: [PATCH v4 20/71] perf/x86/intel/pt: Switch to new Intel CPU model defines

[Dave Hansen]

On 4/24/24 11:15, Tony Luck wrote:
>  	/* model-specific quirks */
> -	switch (boot_cpu_data.x86_model) {
> -	case INTEL_FAM6_BROADWELL:
> -	case INTEL_FAM6_BROADWELL_D:
> -	case INTEL_FAM6_BROADWELL_G:
> -	case INTEL_FAM6_BROADWELL_X:
> +	switch (boot_cpu_data.x86_vfm) {
> +	case INTEL_BROADWELL:
> +	case INTEL_BROADWELL_D:
> +	case INTEL_BROADWELL_G:
> +	case INTEL_BROADWELL_X:
>  		/* not setting BRANCH_EN will #GP, erratum BDM106 */
>  		pt_pmu.branch_en_always_on = true;
>  		break;

Hah, and this actually fixes a theoretical bug because there's no check
for family 6 in this code.