RE: [PATCH v4 24/71] perf/x86/msr: Switch to new Intel CPU model defines

From: Luck, Tony
Date: Thu Apr 25 2024 - 12:54:49 EST


> Well, my point is that a .x86_vfm switch:
>
>> + switch (boot_cpu_data.x86_vfm) {
>> + case INTEL_NEHALEM:
>> + case INTEL_NEHALEM_G:
>
> implicitly checks boot_cpu_data.x86==6. So the explicit check can now
> go away, no matter what CPUs are being checked.

Implicitly checks vendor too. So the whole:

if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL ||
boot_cpu_data.x86 != 6)
return false;

can go away (assuming this isn't used in some performance critical path
where the quick return would make some difference for AMD.

-Tony