Re: [PATCH v1] perf build: Pretend scandirat is missing with msan

[Arnaldo Carvalho de Melo]

On Wed, Mar 20, 2024 at 09:32:44AM -0700, Ian Rogers wrote:
> Memory sanitizer lacks an interceptor for scandirat, reporting all
> memory it allocates as uninitialized. Memory sanitizer has a scandir
> interceptor so use the fallback function in this case. This allows
> perf test to run under memory sanitizer.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
>  tools/perf/Makefile.config | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 1fe8df97fe88..74e0b17050b5 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -486,7 +486,10 @@ ifdef NO_DWARF
>  endif
>  
>  ifeq ($(feature-scandirat), 1)
> -  CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
> +  # Ignore having scandirat with memory sanitizer that lacks an interceptor.
> +  ifeq ($(filter s% -fsanitize=memory%,$(EXTRA_CFLAGS),),)
> +    CFLAGS += -DHAVE_SCANDIRAT_SUPPORT
> +  endif
>  endif
>  
>  ifeq ($(feature-sched_getcpu), 1)
> -- 
> 2.44.0.291.gc1ea87d7ee-goog