Re: [PATCH] perf annotate: Fix data type profiling on stdio

[Arnaldo Carvalho de Melo]

On Tue, Apr 23, 2024 at 04:07:08PM -0700, Namhyung Kim wrote:
> On Tue, Apr 23, 2024 at 9:57 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > On Mon, Apr 22, 2024 at 7:06 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > >
> > > The loop in hists__find_annotations() never set the 'nd' pointer to NULL
> > > and it makes stdio output repeating the last element forever.  I think
> > > it doesn't set to NULL for TUI to prevent it from exiting unexpectedly.
> > > But it should just set on stdio mode.
> > >
> > > Fixes: d001c7a7f473 ("perf annotate-data: Add hist_entry__annotate_data_tui()")
> > > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> >
> > Acked-by: Ian Rogers <irogers@xxxxxxxxxx>
> 
> Thanks for your review!

Thanks, applied to perf-tools-next,

- Arnaldo
 
> >
> > Should we have a test to cover things like this?
> 
> Ok, I'll try to add one for perf annotate.
> 
> Thanks,
> Namhyung