RE: [PATCH wireless-next] wifi: rtw88: Un-embed dummy device

[Ping-Ke Shih]

Breno Leitao <leitao@xxxxxxxxxx> wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
> 
> Un-embed the net_device from the private struct by converting it
> into a pointer. Then use the leverage the new alloc_netdev_dummy()
> helper to allocate and initialize dummy devices.
> 
> [1] https://lore.kernel.org/all/20240229225910.79e224cf@xxxxxxxxxx/
> 
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

Like patch of rtw89, I will take it to my tree weeks later.

> ---
>  drivers/net/wireless/realtek/rtw88/pci.c | 17 +++++++++++++----
>  drivers/net/wireless/realtek/rtw88/pci.h |  2 +-
>  2 files changed, 14 insertions(+), 5 deletions(-)
> 
> PS: This is compile-tested only due to lack of hardware to do better
> testing.

Tested with real hardware RTL8723DE and RTL8822CE. 

Tested-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>