Re: [PATCH] Bluetooth: qca: fix invalid device address check

[Janaki Ramaiah Thota]

On 4/25/2024 9:28 PM, Johan Hovold wrote:
> Hi Janaki,
>
> On Thu, Apr 25, 2024 at 08:31:50PM +0530, Janaki Ramaiah Thota wrote:
>
> > Apologies for the delay. As of now, we have observed the following
> > values in the upstream firmware files for default BD addresses.
> > We will confirm ASAP if there are any changes.
> >
> > ---------------------------------------------------------
> > |   BDA	        |      Chipset		               |
> > ---------------------------------------------------------	
> > | 20 00 00 10 80 39  | WCN3988 with ROM Version 0x0200	|
> > ---------------------------------------------------------	
> > | 00 08 74 12 80 39  |  WCN3988 with ROM Version 0x0201	|
> > ---------------------------------------------------------	
> > | 00 07 64 21 90 39  |  WCN3990			        |
> > ---------------------------------------------------------
>
> Thanks a lot for these. I see now that the default Trogdor address Doug
> reported (39:98:00:00:5a:ad) appears to comes from the fw too:
>
> 	$ od -x crnv32.bin | grep 5aad
>
> 	0000020 0000 0000 5aad 0000 3998 0008 0008 0000
>
> which means that patch I sent this morning should be all that is needed
> for those machines at least.

Yes correct, it will work for Trogdor

> Can you please confirm that all the WCN39xx have OTP storage for an
> address that an OEM can choose to use?

We are checking with internal FW team, will confirm on it.

> If that's not the case then we could simplify things by always marking
> their addresses as invalid, but I assume that they all have address
> storage.
>
> Johan

-Janakiram