Re: [PATCH v4 2/2] arm64: dts: amlogic: Add Amlogic S4 PWM

[Krzysztof Kozlowski]

On 24/04/2024 12:28, Kelvin Zhang via B4 Relay wrote:
> From: Junyi Zhao <junyi.zhao@xxxxxxxxxxx>
> 
> Add device nodes for PWM_AB, PWM_CD, PWM_EF, PWM_GH and PWM_IJ
> along with GPIO PIN configs of each channel.
> 
> Signed-off-by: Junyi Zhao <junyi.zhao@xxxxxxxxxxx>
> Signed-off-by: Kelvin Zhang <kelvin.zhang@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 207 ++++++++++++++++++++++++++++++
>  1 file changed, 207 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index 10896f9df682..8165b263ab92 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -292,6 +292,168 @@ mux {
>  					};
>  				};
>  
> +				pwm_a_pins1: pwm_a_pins1 {

No underscores in node names.

Best regards,
Krzysztof