Re: [EXTERNAL] Re: [PATCH v5 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver

[Greg KH]

On Thu, Apr 25, 2024 at 01:36:05PM +0000, Vamsi Krishna Attunuru wrote:
> > 
> > > -----Original Message-----
> > > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Sent: Friday, April 12, 2024 5:57 PM
> > > To: Vamsi Krishna Attunuru <vattunuru@xxxxxxxxxxx>
> > > Cc: arnd@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > > Subject: [EXTERNAL] Re: [PATCH v5 1/1] misc: mrvl-cn10k-dpi: add
> > > Octeon CN10K DPI administrative driver
> > >
> > > Prioritize security for external emails: Confirm sender and content
> > > safety before clicking links or opening attachments
> > >
> > > ----------------------------------------------------------------------
> > > On Fri, Apr 12, 2024 at 05:10:05AM -0700, Vamsi Attunuru wrote:
> > > > Adds a misc driver for Marvell CN10K DPI(DMA Engine) device's
> > > > physical function which initializes DPI DMA hardware's global
> > > > configuration and enables hardware mailbox channels between physical
> > > > function (PF) and it's virtual functions (VF). VF device drivers
> > > > (User space drivers) use this hw mailbox to communicate any required
> > > > device configuration on it's respective VF device. Accordingly, this
> > > > DPI PF driver provisions the VF device resources.
> > > >
> > > > At the hardware level, the DPI physical function (PF) acts as a
> > > > management interface to setup the VF device resources, VF devices
> > > > are only provisioned to handle or control the actual DMA Engine's
> > > > data transfer
> > > capabilities.
> > >
> > > No pointer to the userspace code that uses this?  Why not?  How are we
> > > supposed to be able to review this?
> > 
> Hi Greg, please check the below files for userspace code that interact with this kernel driver.
> driver/roc_dpi.c provides the mailbox interface to communicate with this kernel driver.
> application/main.c is the DPI DMA application which uses this misc driver to configure
> the device with required mps, mrrs, fifo_mask parameters.
> 
> https://github.com/VamsiKrishnaA99/dpi-dma/blob/main/driver/roc_dpi.c 
> https://github.com/VamsiKrishnaA99/dpi-dma/blob/main/application/main.c

Please provide this information in a new version of the patch, looking
at this now when we don't have the kernel code present is almost
impossible, sorry.

thanks,

greg k-h