Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

From: Ilpo Järvinen
Date: Fri Apr 26 2024 - 09:48:33 EST


On Fri, 26 Apr 2024, lumingyindetect@xxxxxxx wrote:

> From: LuMingYin <lumingyindetect@xxxxxxx>
>
> The return statements at line 347 and line 351 in the lpss8250_probe() function result in a memory leak of the variable pdev.
> Add a label named free_irq_vectors in the lpss8250_probe() function to release the memory area pointed to by pdev.
> Modify the two return statements mentioned above to jump to the label "free_irq_vectors" instead.

Also, this is not a 100m sprint. Please leave time for people to comment
on your previous submission before sending the next version out.

People are from different timezones and have other things to look too
besides your patch so they might not be happy if they find 4 versions of
your patch in their inbox before even having time to look at the first
one.

--
i.