Re: [PATCH] "drivers:Fixed memory leak in /linux/drivers/tty/serial/8250/8250_lpss.c file.

From: Andy Shevchenko
Date: Fri Apr 26 2024 - 10:34:57 EST


On Fri, Apr 26, 2024 at 03:19:39AM +0100, lumingyindetect@xxxxxxx wrote:
> From: LuMingYin <11570291+yin-luming@xxxxxxxxxxxxxxxxxxxxxx>
>
> In the lpss8250_probe function in the file
> /linux/drivers/tty/serial/8250/8250_lpss.c, there were certain return paths
> where pci_free_irq_vectors was not called to release memory related to pdev,
> leading to a memory leak. This commit fixes that issue."

This patch does not fix anything. The driver uses pcim_enable_device()
which changes how this all behaves.

NAK.

--
With Best Regards,
Andy Shevchenko