Re: [PATCH v1 1/1] zorro: Use helpers from ioport.h

[Geert Uytterhoeven]

Hi Andy,

On Fri, Apr 26, 2024 at 5:33 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Mon, Sep 04, 2023 at 11:31:03AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Aug 31, 2023 at 2:16 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > We can use the DEFINE_RES_MEM_NAMED() macro and resource_contains() helper
> > > instead of reimplementing them in the code. No functional change intended.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/drivers/zorro/zorro.c
> > > +++ b/drivers/zorro/zorro.c
> > > @@ -117,17 +117,13 @@ static struct resource __init *zorro_find_parent_resource(
> > >         int i;
> > >
> > >         for (i = 0; i < bridge->num_resources; i++) {
> > > -               struct resource *r = &bridge->resource[i];
> > > -
> > > -               if (zorro_resource_start(z) >= r->start &&
> > > -                   zorro_resource_end(z) <= r->end)
> > > -                       return r;
> > > +               if (resource_contains(&bridge->resource[i], &z->resource)
> >
> > Missing closing parenthesis. What happened to your cross-compiler?
> >
> > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > i.e. will queue in the m68k for-v6.7 branch, with the above fixed.
>
> Seems never got queued, should I send a v2 with the above fixed?

Oops, will queue in the m68k tree for v6.10.
No need to resend, I still have a fixed copy in my local tree.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds