Re: [PATCH 6/7] dt-bindings: iio: imu: Add ADIS1657X family devices compatibles

[Conor Dooley]

On Fri, Apr 26, 2024 at 04:53:38PM +0300, Ramona Gradinariu wrote:
> Add ADIS1657X family devices compatibles and specify the according
> maximum SPI baudrate.
> Similarly to other ADIS1650X devices, ADIS1657X supports sync-mode
> values [0,2].
> 
> Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@xxxxxxxxx>
> ---
>  .../bindings/iio/imu/adi,adis16475.yaml       | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> index db52e7063116..9d185f7bfdcb 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> @@ -37,6 +37,12 @@ properties:
>        - adi,adis16507-1
>        - adi,adis16507-2
>        - adi,adis16507-3
> +      - adi,adis16575-2
> +      - adi,adis16575-3
> +      - adi,adis16576-2
> +      - adi,adis16576-3
> +      - adi,adis16577-2
> +      - adi,adis16577-3

I'm not checking all of the structs for these ones against eachother,
please explain why fallback compatible are not suitable.

Thanks,
Conor.

>  
>    reg:
>      maxItems: 1
> @@ -98,6 +104,12 @@ allOf:
>                - adi,adis16507-1
>                - adi,adis16507-2
>                - adi,adis16507-3
> +              - adi,adis16575-2
> +              - adi,adis16575-3
> +              - adi,adis16576-2
> +              - adi,adis16576-3
> +              - adi,adis16577-2
> +              - adi,adis16577-3
>  
>      then:
>        properties:
> @@ -114,6 +126,23 @@ allOf:
>        dependencies:
>          adi,sync-mode: [ clocks ]
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,adis16575-2
> +              - adi,adis16575-3
> +              - adi,adis16576-2
> +              - adi,adis16576-3
> +              - adi,adis16577-2
> +              - adi,adis16577-3
> +
> +    then:
> +      properties:
> +        spi-max-frequency:
> +          maximum: 15000000
> +
>  unevaluatedProperties: false
>  
>  examples:
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature