Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board

From: Andrew Lunn
Date: Fri Apr 26 2024 - 14:18:19 EST


> >> Colours are similar to RJ45 connectors (yellow, green),
> >> and are intended for the same purpose: link, activity.
> > For the switch LEDs you used label = "LED10"; Does the silk screen
> > have similar numbers for these LEDs?
> Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled
> individually on the silk screen.
>
> The SolidWAN SFP leds are dual-colour leds with 3 terminals:
> anode to 3.3V, 2x cathode to gpio-controlled transistors.
> They are labeled on the silk-screen as "LED9", "LED10".
>
> Duplicate labels are not great, is there a better way?
> old style "LED9:green" e.g. ...?

So you have copper LEDs and SFP LEDs, each with the same silk screen
label? Maybe put 'copper' and 'sfp' as a prefix into the label?

Andrew