Re: [PATCH net-next v2 1/3] net/mlx4: Track RX allocation failures in a stat

From: Jakub Kicinski
Date: Fri Apr 26 2024 - 20:34:20 EST


On Fri, 26 Apr 2024 17:28:03 -0700 Joe Damato wrote:
> Ah, maybe I read what you wrote incorrectly in your previous message.
>
> I think you were saying that I should drop just the
>
> dev->stats.rx_missed_errors = dropped;
>
> due to the definition of rx_missed_errors, but that by the definition of
> rx-alloc-fail:
>
> alloc_fail = ring->dropped;
>
> is still valid and can stay.

That's right, yes.