Re: [PATCH net 4/4] net: qede: use return from qede_parse_actions()

From: Simon Horman
Date: Sat Apr 27 2024 - 13:38:14 EST


On Fri, Apr 26, 2024 at 09:12:26AM +0000, Asbjørn Sloth Tønnesen wrote:
> When calling qede_parse_actions() then the
> return code was only used for a non-zero check,
> and then -EINVAL was returned.
>
> qede_parse_actions() can currently fail with:
> * -EINVAL
> * -EOPNOTSUPP
>
> This patch changes the code to use the actual
> return code, not just return -EINVAL.
>
> The blaimed commit broke the implicit assumption
> that only -EINVAL would ever be returned.
>
> Only compile tested.
>
> Fixes: 319a1d19471e ("flow_offload: check for basic action hw stats type")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>