Re: [PATCH 1/4] hwmon (max6639): Use regmap

From: Guenter Roeck
Date: Sun Apr 28 2024 - 13:19:01 EST


On 4/25/24 02:50, Naresh Solanki wrote:
..
This driver has 27 regmap accesses. Except volatile registers, others are
cached by regmap.
Some function which only access volatile registers will not be able to take
advantage of caching. This is also the case in various other drivers for similar
devices.
Also regmap offers bit handling which makes the code much cleaner.


Maybe I need to make it explicit in documentation. I will not accept regmap
conversions unless local caching is dropped. Yes, that means that volatile
registers will not be cached. I consider that a positive.

Guenter