Re: [tip: x86/cpu] x86/mce: Switch to new Intel CPU model defines

From: Borislav Petkov
Date: Sun Apr 28 2024 - 14:32:02 EST


On Fri, Apr 26, 2024 at 06:12:11PM -0000, tip-bot2 for Tony Luck wrote:
> @@ -398,7 +398,7 @@ static noinstr int mce_severity_intel(struct mce *m, struct pt_regs *regs, char
> continue;
> if (s->excp && excp != s->excp)
> continue;
> - if (s->cpu_model && boot_cpu_data.x86_model != s->cpu_model)
> + if (s->cpu_vfm && boot_cpu_data.x86_model != s->cpu_vfm)

Hold on, isn't this supposed to be:

if (s->cpu_vfm && boot_cpu_data.cpu_vfm != s->cpu_vfm)

?

You're getting rid of the ->x86_model checking altogether...

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette