Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register

From: Anshuman Khandual
Date: Sun Apr 28 2024 - 22:12:29 EST




On 4/23/24 10:47, Mark Brown wrote:
> On Mon, Apr 22, 2024 at 06:16:13PM +0100, Will Deacon wrote:
>> On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:
>
>>> This is not being used currently but will be required for upcoming
>>> features. I was under the impression that register fields (atleast
>>> for the ID registers) should be kept updated, with latest released
>>> spec ? Besides lately arch/arm64/tools/sysreg serves as very good
>>> reference for all necessary register fields.
>
>> Why? The linux headers aren't documenting the architecture.
>
> I don't know that it's something that we should be doing apropos of
> nothing but if people have done updates and they're not unreasonbly
> complicated to review it does seem useful to integrate them to avoid
> duplicated work. There have been some issues with that around the ID
> registers (which are going to be on the places most prone to this I
> guess).

The other problem is by not updating the individual register fields with
the latest spec, it also gives an wrong impression about that field, and
also might create confusion.