Re: [PATCH v7 6/6] platform: x86-android-tablets: others: Set the LED trigger to charging_orange_full_green for Xiaomi pad2

From: Hans de Goede
Date: Mon Apr 29 2024 - 07:10:57 EST


Hi,

On 4/24/24 8:52 AM, Kate Hsuan wrote:
> Set the default trigger to bq27520-0-charging-orange-full-green. The LED
> will show orange when the battery is charging. The LED will show green
> when the battery status is full.
>
> Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans



> ---
> drivers/platform/x86/x86-android-tablets/other.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c
> index c77d56454f2d..52032a874b7f 100644
> --- a/drivers/platform/x86/x86-android-tablets/other.c
> +++ b/drivers/platform/x86/x86-android-tablets/other.c
> @@ -610,7 +610,7 @@ static const struct property_entry ktd2026_rgb_led_props[] = {
> PROPERTY_ENTRY_U32("reg", 0),
> PROPERTY_ENTRY_U32("color", LED_COLOR_ID_RGB),
> PROPERTY_ENTRY_STRING("function", "indicator"),
> - PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging"),
> + PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging-orange-full-green"),
> { }
> };
>