Re: [PATCH v6 5/5] arm64: dts: ti: k3-j784s4: Add overlay for dual port USXGMII mode

[Chintan Vankar]

On 29/04/24 16:01, Krzysztof Kozlowski wrote:
> On 29/03/2024 06:31, Chintan Vankar wrote:
> > From: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> >
> > The CPSW9G instance of the CPSW Ethernet Switch supports USXGMII mode
> > with MAC Ports 1 and 2 of the instance, which are connected to ENET
> > Expansion 1 and ENET Expansion 2 slots on the EVM respectively, through
> > the Serdes2 instance of the SERDES.
> >
> > Enable CPSW9G MAC Ports 1 and 2 in fixed-link configuration USXGMII mode
> > at 5 Gbps each.
> >
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> > Signed-off-by: Chintan Vankar <c-vankar@xxxxxx>
> > ---
> >
> > Link to v5:
> > https://lore.kernel.org/r/20240314072129.1520475-6-c-vankar@xxxxxx/
> >
> > Changes from v5 to v6:
> > - Updated order of properties in Device Nodes based on
> >    https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
> >
> >   arch/arm64/boot/dts/ti/Makefile               |  6 +-
> >   .../ti/k3-j784s4-evm-usxgmii-exp1-exp2.dtso   | 81 +++++++++++++++++++
> >   2 files changed, 86 insertions(+), 1 deletion(-)
> >   create mode 100644 arch/arm64/boot/dts/ti/k3-j784s4-evm-usxgmii-exp1-exp2.dtso
> >
> > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> > index f8e47278df43..2d798ef415e4 100644
> > --- a/arch/arm64/boot/dts/ti/Makefile
> > +++ b/arch/arm64/boot/dts/ti/Makefile
> > @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm.dtb
> >   dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
> >   dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm.dtb
> >   dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-quad-port-eth-exp1.dtbo
> > +dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm-usxgmii-exp1-exp2.dtbo
> >   
> >   # Build time test only, enabled by CONFIG_OF_ALL_DTBS
> >   k3-am625-beagleplay-csi2-ov5640-dtbs := k3-am625-beagleplay.dtb \
> > @@ -148,6 +149,8 @@ k3-j721s2-evm-pcie1-ep-dtbs := k3-j721s2-common-proc-board.dtb \
> >   	k3-j721s2-evm-pcie1-ep.dtbo
> >   k3-j784s4-evm-quad-port-eth-exp1-dtbs := k3-j784s4-evm.dtb \
> >   	k3-j784s4-evm-quad-port-eth-exp1.dtbo
> > +k3-j784s4-evm-usxgmii-exp1-exp2.dtbs := k3-j784s4-evm.dtb \
> > +	k3-j784s4-evm-usxgmii-exp1-exp2.dtbo\
>
> I have doubts this commit was ever built. It clearly fails, just like
> now linux-next fails.

Apologies for the syntax error here, I will fix it and post next
version.

> Best regards,
> Krzysztof